refactor: clean up code and improve error handling in authentication and database modules

auth/src/storage/database.js

@@ -5,74 +5,46 @@ const config = {
     password: process.env.DB_PASSWORD,
     host: process.env.DB_HOST,
     port: process.env.DB_PORT,
+    database: process.env.USERS_DB || process.env.DB_NAME,
     max: 10,
     idleTimeoutMillis: 30000,
     connectionTimeoutMillis: 5000
-}
+};
 
-const pool = new Pool({ ...config, database: process.env.USERS_DB });
+const pool = new Pool(config);
 
 pool.on('error', (err) => {
-    console.error('Error in database', err);
+    console.error('[DB] Pool error:', err.message);
 });
 
-/**
- * Execute a query with parameters
- * @param {string} text - SQL query
- * @param {Array} params - Query parameters
- * @returns {Promise<Object>} Query result
- */
 async function query(text, params) {
     const start = Date.now();
-    console.log('[DEBUG DB] Executing query:', text.substring(0, 120));
-    if (params && params.length > 0) {
-        console.log('[DEBUG DB] Parameters:', params);
-    }
-    
     try {
         const result = await pool.query(text, params);
         const duration = Date.now() - start;
-
         if (duration > 100) {
             console.warn(`[DB] Slow query (${duration}ms):`, text.substring(0, 80));
         }
-        
-        console.log('[DEBUG DB] Query successful - rows:', result.rowCount, 'duration:', duration + 'ms');
         return result;
     } catch (err) {
-        const duration = Date.now() - start;
-        console.error('[DEBUG DB] Query FAILED:', err.message);
-        console.error('[DEBUG DB] Error code:', err.code);
-        console.error('[DEBUG DB] Query:', text.substring(0, 120));
-        console.error('[DEBUG DB] Duration:', duration + 'ms');
-        console.error('[DEBUG DB] Full error:', err);
+        console.error('[DB] Query failed:', err.message, '| code:', err.code);
         throw err;
     }
 }
 
-/**
- * Get a client from pool for transactions
- * @returns {Promise<Object>} Pool client
- */
 async function getClient() {
     return await pool.connect();
 }
 
-/**
- * Initialize database and ensure tables exist
- */
 async function initDb() {
-    // Test connection
     await pool.query('SELECT NOW()');
-    // Ensure pgcrypto extension (provides gen_random_uuid)
-    // Note: creating extensions requires proper DB permissions (usually superuser in PG)
+
     try {
         await pool.query(`CREATE EXTENSION IF NOT EXISTS pgcrypto;`);
     } catch (err) {
-        console.warn('[DB] Could not create pgcrypto extension (may require superuser):', err.message);
+        console.warn('[DB] Could not create pgcrypto extension:', err.message);
     }
 
-    // Ensure tables exist (UUID default generated by DB)
     await pool.query(`
         CREATE TABLE IF NOT EXISTS users (
             id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
@@ -92,7 +64,7 @@ async function initDb() {
             id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
             user_id UUID NOT NULL REFERENCES users(id) ON DELETE CASCADE,
             session_code VARCHAR(64) NOT NULL,
-            encoded_username TEXT NOT NULL,
+            encoded_username TEXT NOT NULL DEFAULT '',
             ip_address INET,
             user_agent TEXT,
             browser VARCHAR(100),
@@ -105,9 +77,6 @@ async function initDb() {
             is_revoked BOOLEAN DEFAULT FALSE
         );
 
-        -- Altera colonna in base al nuovo standard token 32 byte - 64 url chars
-        ALTER TABLE sessions ALTER COLUMN session_code TYPE VARCHAR(64);
-
         CREATE INDEX IF NOT EXISTS idx_sessions_code ON sessions(session_code);
         CREATE INDEX IF NOT EXISTS idx_sessions_user_id ON sessions(user_id);
     `);
@@ -117,7 +86,7 @@ async function checkPostgres() {
     try {
         await pool.query('SELECT NOW()');
         return true;
-    } catch (error) {
+    } catch {
         return false;
     }
 }